Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: copy ensemble_boxes_nms from ensemble_boxes package #98

Merged
merged 2 commits into from
Dec 21, 2024

Conversation

RanbirAulakh
Copy link
Collaborator

Issue #, if available: n/a

Notes

This file contains code for performing non-maximum suppression (NMS) on bounding boxes obtained from multiple object detection models. The code was originally taken from the following GitHub repository:

https://github.com/ZFTurbo/Weighted-Boxes-Fusion/blob/master/ensemble_boxes/ensemble_boxes_nms.py

The original author is 'ZFTurbo' (https://kaggle.com/zfturbo).

This implementation provides functions for standard NMS, linear soft-NMS, and gaussian soft-NMS. It also includes a method for preparing the boxes, scores, and labels before applying NMS.

Along with some motification to match the conventional OSML styles such as typings and docstrings.

Checklist

Before you submit a pull request, please make sure you have the following:

  • Code changes are compact and well-structured to facilitate easy review
  • Changes are documented in the README.md and other relevant documentation pages
  • PR title and description accurately reflect the changes and are detailed enough for historical tracking
  • PR contains tests that cover all new code and the code has been manual tested
  • All new dependencies are declared (if any), and no unnecessary libraries are added
  • Performance impacts (if any) of the changes are evaluated and documented
  • Security implications of the changes (if any) are reviewed and addressed
  • I have read the Contributing Guidelines and agree to follow the Code of Conduct

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@RanbirAulakh RanbirAulakh force-pushed the hash-collision branch 3 times, most recently from 2e2aac3 to e226e30 Compare October 11, 2024 19:00
@drduhe drduhe force-pushed the hash-collision branch 5 times, most recently from ac45f9a to 11214ff Compare December 17, 2024 20:29
Copy link
Collaborator

@drduhe drduhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RanbirAulakh RanbirAulakh merged commit 4fde219 into main Dec 21, 2024
2 checks passed
@RanbirAulakh RanbirAulakh deleted the hash-collision branch December 21, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants