refactor: implement ImageRequestHandler class #102
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: n/a
Notes
This PR introduces refactoring of the
ImageRequestHandler
class to decouple region processing logic fromModelRunner
. TheImageRequestHandler
now makes it the image processing logic self-contained, modular, and easier to test. Additionally, changes to theModelRunner
class were made to initialize this handler with the appropriate dependencies. Methods were refined in theImageRequestHandler
class to make them more compact and testable.Unit tests were updated to split out region processing testing associated with the new class.
Additional method was added to the
JobItem
dataclass which allows conversion to from anImageRequest
to aJobItem
.Checklist
Before you submit a pull request, please make sure you have the following:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.