Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate kinesis extends to appends #46

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

RanbirAulakh
Copy link
Collaborator

@RanbirAulakh RanbirAulakh commented Sep 23, 2024

Issue #, if available: n/a

Notes

  • Change extends to appends since we have shifted the kinesis data stream from put_record to put_records.

It depends on this PR to be merged in: aws-solutions-library-samples/osml-model-runner#92

Checklist

Before you submit a pull request, please make sure you have the following:

  • Code changes are compact and well-structured to facilitate easy review
  • Changes are documented in the README.md and other relevant documentation pages
  • PR title and description accurately reflect the changes and are detailed enough for historical tracking
  • PR contains tests that cover all new code and the code has been manual tested
  • All new dependencies are declared (if any), and no unnecessary libraries are added
  • Performance impacts (if any) of the changes are evaluated and documented
  • Security implications of the changes (if any) are reviewed and addressed
  • I have read the Contributing Guidelines and agree to follow the Code of Conduct

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Collaborator

@drduhe drduhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RanbirAulakh RanbirAulakh merged commit e641287 into main Sep 24, 2024
1 check passed
@RanbirAulakh RanbirAulakh deleted the fix-kinesis-test branch September 24, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants