fix: generic dem tile names for SW hemisphere #63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an error in how the DEM file names are calculated by the GenericDEMTileSet. The original code did not handle coordinates in the South or West hemispheres correctly (negative decimal degrees values). The DEM tile 044W contains elevation values for coordinates [-44.0, -43.0) so a coordinate value of -43.5 needs to be floored to -44. That is the natural behavior of the python floor() operator but the original implementation was relying on the degrees, minutes, seconds calculation in the GeodeticWorldCoordinate format operator which converts the decimal value to a positive number before truncating the degrees. This change floors the number before passing it into the format string ensuring the correct decimal value is chosen for a DEM tile. Unit tests have been updated to include the failing example that brought this issue to our attention.
Checklist
Before you submit a pull request, please make sure you have the following:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.