Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to create map tiles from SICD images #58

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

edparris
Copy link
Contributor

This change adds the ability to create map tiles from SAR images with complex pixel values. The changes to the GDALTileFactory include updates to convert the 2-band phase/amplitude SICD imagery into an 8-bit per pixel single band imagery meant for human review. This is similar to the dynamic range adjustment normalization applied to electro-optical imagery but it differs in that multiple bands are being combined and normalized to produce a single output image. The calculations in create_orthophoto_tile were also updated to provide a better elevation estimations and more consistent mapping of image pyramid level to map tile resolution. These changes will improve the map tiles generated for all sensor types but the effect was particularly noticeable on the test SAR imagery.

Unit tests have been updated to cover both SICD and SIDD imagery (SIDD already worked but was untested). Manual integration tests were completed to ensure that the results rendered properly in a tile server visualized by a STAC browser. (see images below)

Manual Test Example 1: A SICD image available from AWS's open data program overlaid on a map.
Screenshot 2024-10-11 at 3 41 37 PM

Manual Test Example 2: EO image tiles showing no regression from changes made to support SICD.
Screenshot 2024-10-11 at 5 28 32 PM

Checklist

Before you submit a pull request, please make sure you have the following:

  • Code changes are compact and well-structured to facilitate easy review
  • Changes are documented in the README.md and other relevant documentation pages
  • PR title and description accurately reflect the changes and are detailed enough for historical tracking
  • PR contains tests that cover all new code and the code has been manual tested
  • All new dependencies are declared (if any), and no unnecessary libraries are added
  • Performance impacts (if any) of the changes are evaluated and documented
  • Security implications of the changes (if any) are reviewed and addressed
  • I have read the Contributing Guidelines and agree to follow the Code of Conduct

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

@batzela batzela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@edparris edparris merged commit 4ac946b into main Oct 14, 2024
1 check passed
@edparris edparris deleted the feature/sicd-orthophoto-tiles branch October 14, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants