feat: adding an alpha mask to ortho map tiles for pixels in the tile but outside the image #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edparris
reviewed
Sep 13, 2024
edparris
reviewed
Sep 13, 2024
jtblack-aws
force-pushed
the
feat/map-alpha-mask
branch
from
744db1a to
a8078a2
Compare
…but outside the image
jtblack-aws
force-pushed
the
feat/map-alpha-mask
branch
from
a8078a2 to
378dbea
Compare
edparris
approved these changes
Sep 18, 2024
drduhe
approved these changes
Sep 18, 2024
| @@ -17,4 +17,4 @@ partial_branches = | |||
|
|
|||
| show_missing = True | |||
|
|
|||
| fail_under = 60 | |||
| fail_under = 96 | |||
| @@ -223,6 +223,31 @@ def test_create_map_tiles_for_image(self): | |||
| assert tile_dataset.RasterYSize == 256 | |||
| assert tile_dataset.GetDriver().ShortName == GDALImageFormats.PNG | |||
|
|
|||
| def test_create_map_tiles_for_color_image(self): | |||
There was a problem hiding this comment.
Not to address now - but I have been adding comments to our tests to describe what they are doing in other packages. Just leaving a breadcrumb for this here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: n/a
Notes
Adding an alpha layer to map tiles to account for cases when the image data does not completely fill the map tile. Previously these pixels would be filled with black which obstructed the view of lower map layers.
Checklist
Before you submit a pull request, please make sure you have the following:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.