fix: incorrect SICD/SIDD metadata added by tile factory #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change corrects a problem that caused the GDALTileFactory to write incorrect XML metadata with SICD tiles. Metadata of that kind is provided to the underlying gdal.translate() function through a dictionary of keyword arguments. Some of those arguments remain the same for an entire image while others vary from tile to tile. When multiple tiles were created from the same image some arguments were carried forward to other chips due to a programming error (a shallow vs. deep copy of an argument that was itself a list of values). As a consequence all tiles after the first one may have incorrect metatada encoded that was leftover from previous tiles.
Notes
Changes have been verified in an integration test environment and are being released ASAP given the severity of the issue. Follow-on PRs will address the gaps in automated testing.
Checklist
Before you submit a pull request, please make sure you have the following:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.