Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect SICD/SIDD metadata added by tile factory #50

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

edparris
Copy link
Contributor

This change corrects a problem that caused the GDALTileFactory to write incorrect XML metadata with SICD tiles. Metadata of that kind is provided to the underlying gdal.translate() function through a dictionary of keyword arguments. Some of those arguments remain the same for an entire image while others vary from tile to tile. When multiple tiles were created from the same image some arguments were carried forward to other chips due to a programming error (a shallow vs. deep copy of an argument that was itself a list of values). As a consequence all tiles after the first one may have incorrect metatada encoded that was leftover from previous tiles.

Notes

Changes have been verified in an integration test environment and are being released ASAP given the severity of the issue. Follow-on PRs will address the gaps in automated testing.

Checklist

Before you submit a pull request, please make sure you have the following:

  • Code changes are compact and well-structured to facilitate easy review
  • Changes are documented in the README.md and other relevant documentation pages
  • PR title and description accurately reflect the changes and are detailed enough for historical tracking
  • PR contains tests that cover all new code and the code has been manual tested
  • All new dependencies are declared (if any), and no unnecessary libraries are added
  • Performance impacts (if any) of the changes are evaluated and documented
  • Security implications of the changes (if any) are reviewed and addressed
  • I have read the Contributing Guidelines and agree to follow the Code of Conduct

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@edparris edparris merged commit dc8dc30 into main Aug 14, 2024
1 check passed
@edparris edparris deleted the fix/incorrect-sar-metadata branch August 14, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants