feat: add support for sidd imagery #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| :return: the sensor model; if available | ||
| """ | ||
| try: | ||
| if self.sidd_xml is None or len(self.sidd_xml) == 0: |
There was a problem hiding this comment.
I would use if not self.sidd.xml: and eliminate the rest according to the PEPS8
For sequences, (strings, lists, tuples), use the fact that empty sequences are false:
# Correct:
if not seq:
if seq:
# Wrong:
if len(seq):
if not len(seq):
| return u_spn | ||
|
|
||
| @staticmethod | ||
| def compute_u_gpn(scp_ecf: WorldCoordinate, u_row: np.ndarray, u_col: np.ndarray) -> np.ndarray: |
There was a problem hiding this comment.
Missing documentation for this.
drduhe
approved these changes
Oct 11, 2023
| @@ -24,7 +24,7 @@ repos: | |||
| rev: 6.0.0 | |||
| hooks: | |||
| - id: flake8 | |||
| args: ["--ignore=E203,W503,W605", "--max-line-length=125"] | |||
| args: ["--ignore=E203,W503,W605", "--max-line-length=160", "--extend-exclude=src/aws/osml/formats"] | |||
There was a problem hiding this comment.
Would we like to standardize on 160 in other packages as the max line length?
There was a problem hiding this comment.
The only reason I did this is that there are some long regular expression strings in the XML parsing code. They look really ugly if they get broken up.
The black formatter still sets things to 125 which seems like a generally good practice. The only reason I set this here is because flake8 seems to be ignoring that excludes option so it was still complaining about the XML format files.
edparris
added a commit
that referenced
this pull request
Dec 12, 2023
…ities (#32) This release extends OversightML Imagery Toolkit support to include additional image formats and processing utilities. Key changes include: * Support for SAR imagery including the SICD, and SIDD sensor models and ability to create georeferenced tiles. Also includes basic preprocessing utilities for converting complex data into 8-bit grayscales for display. * RSM sensor models are enabled by default for datasets created using load_gdal_dataset(). * Addition of an optional output_size parameter for the GDALTileFactory that can be used to produce reduced resolution tiles. * Addition of a new aws.osml.features module that contains utilities for working with GeoJSON features derived from imagery. These utilities include spatial indices for creating vector tiles and utilities for working with properties of features that have both geospatil and pixel coordinates. --------- Pull Requests Merged: * feat: add SICD sensor model with planar projection (#10) * feat: add optional dynamic pixel range operations to tile factory (#9) * feat: add HAE and DEM projections to SICD sensor model (#12) * feat: Fix documentation commands for github actions (#13) * docs: Updating CONTRIBUTING.md (#11) * fix: correct calculation of INCA R/Rdot projection (#14) * feat: update DRA to work with SICDs (#15) * feat: enable RSM sensor model by default (#16) * feat: gdal sensor model now supports non-wgs84 crs (#17) * docs: update readme for SAR features (#18) * feat: SAR examples and display processing (#21) * feat: add support for sidd imagery (#22) * feat: Update GitHub actions (#23) * build: Update Github Actions * fix: errors constructing RSMSectionedPolynomialSensorModel from TREs * feat: adds features module with 2D spatial index and basic property utils * feat: adds generic DEM tile set and geodetic coordinate formatting * fix: lint error in generic_dem_tile_set.py * feat: add ability to create scaled tiles and tiles from SIDD * docs: add examples to package level documentation * build: update library version to v1.2.0 --------- Co-authored-by: Ranbir Aulakh <[email protected]> Co-authored-by: drduhe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the ability to work with SIDD imagery and metadata in the OSML imagery toolkit. Sensor models for both full and chipped SIDD imagery are available through the regular load_gdal_dataset() function.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.