Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update roles #150

Merged
merged 1 commit into from
Sep 16, 2024
Merged

fix: update roles #150

merged 1 commit into from
Sep 16, 2024

Conversation

drduhe
Copy link
Collaborator

@drduhe drduhe commented Sep 11, 2024

Issue #, if available: n/a

Notes

Updating roles to longer use default configurations when setting permissions, this avoids deployments breaking when users have provided custom configurations that don't match the defaults. Additionally updating the dockerfile path to match upstream changes to the osml-models package.

Before you submit a pull request, please make sure you have the following:

  • Code changes are compact and well-structured to facilitate easy review
  • Changes are documented in the README.md and other relevant documentation pages
  • PR title and description accurately reflect the changes and are detailed enough for historical tracking
  • PR contains tests that cover all new code and the code has been manual tested
  • All new dependencies are declared (if any), and no unnecessary libraries are added
  • Performance impacts (if any) of the changes are evaluated and documented
  • Security implications of the changes (if any) are reviewed and addressed
  • I have read the Contributing Guidelines and agree to follow the Code of Conduct

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

github-actions bot commented Sep 11, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
91.42% (-0.36% 🔻)
618/676
🔴 Branches
57.23% (-0.58% 🔻)
99/173
🟢 Functions 96.3% 52/54
🟢 Lines
91.42% (-0.36% 🔻)
618/676
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / ts_dataplane.ts
86.25%
52.17% (-4.35% 🔻)
100% 86.25%

Test suite run success

24 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from 5489c3a

@drduhe drduhe merged commit 812de87 into main Sep 16, 2024
2 checks passed
@drduhe drduhe deleted the fix/update-roles branch September 16, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants