Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename sync to sink #142

Merged
merged 1 commit into from
Aug 13, 2024
Merged

fix: rename sync to sink #142

merged 1 commit into from
Aug 13, 2024

Conversation

markveerman
Copy link

@markveerman markveerman commented Aug 12, 2024

Issue #, if available: n/a

Notes

In this context, a sink is the destination of a data flow (S3, Kinesis, etc.) so sync is incorrect and may cause confusion.

Checklist

Before you submit a pull request, please make sure you have the following:

  • Code changes are compact and well-structured to facilitate easy review
  • Changes are documented in the README.md and other relevant documentation pages
  • PR title and description accurately reflect the changes and are detailed enough for historical tracking
  • PR contains tests that cover all new code and the code has been manual tested
  • All new dependencies are declared (if any), and no unnecessary libraries are added
  • Performance impacts (if any) of the changes are evaluated and documented
  • Security implications of the changes (if any) are reviewed and addressed
  • I have read the Contributing Guidelines and agree to follow the Code of Conduct

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

In this context, a sink is the destination of a data flow (S3, Kinesis, etc.) so sync is incorrect and may cause confusion.
Copy link

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 91.35% 665/728
🔴 Branches 58.14% 100/172
🟢 Functions 98.25% 56/57
🟢 Lines 91.35% 665/728

Test suite run success

30 tests passing in 16 suites.

Report generated by 🧪jest coverage report action from 40fbd7e

Copy link
Collaborator

@drduhe drduhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markveerman markveerman merged commit 1c123f2 into main Aug 13, 2024
2 checks passed
@markveerman markveerman deleted the fix/rename-sync-to-sync branch August 13, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants