Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding leading / to fastapi path to delimit domain #136

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

jtblack-aws
Copy link
Contributor

@jtblack-aws jtblack-aws commented Jul 26, 2024

Issue #, if available: n/a

Notes

Restoring the leading / to the data catalog's STAC_FASTAPI_ROOT_PATH.

Checklist

Before you submit a pull request, please make sure you have the following:

  • Code changes are compact and well-structured to facilitate easy review
  • Changes are documented in the README.md and other relevant documentation pages
  • PR title and description accurately reflect the changes and are detailed enough for historical tracking
  • PR contains tests that cover all new code and the code has been manual tested
  • All new dependencies are declared (if any), and no unnecessary libraries are added
  • Performance impacts (if any) of the changes are evaluated and documented
  • Security implications of the changes (if any) are reviewed and addressed
  • I have read the Contributing Guidelines and agree to follow the Code of Conduct

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Collaborator

@drduhe drduhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 93.6% 907/969
🟡 Branches 75.3% 253/336
🟢 Functions 100% 66/66
🟢 Lines 93.6% 907/969

Test suite run success

51 tests passing in 24 suites.

Report generated by 🧪jest coverage report action from 6698ad7

@jtblack-aws jtblack-aws merged commit 1fceca5 into main Jul 26, 2024
2 checks passed
@jtblack-aws jtblack-aws deleted the fix/fastapi-path branch July 26, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants