-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: decouple di dc #278
Merged
Merged
fix: decouple di dc #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please review the existing CDK-Nag Violations for 52b3f33f1859991f9c2f74717e4032177fe640a4 There are 92 AwsSolutions Violation(s)
There are 61 NIST.800.53.R5 Violation(s)
|
drduhe
force-pushed
the
fix/decouple-di-dc
branch
3 times, most recently
from
January 10, 2025 21:41
a2232dd
to
2499221
Compare
RanbirAulakh
previously approved these changes
Jan 10, 2025
drduhe
force-pushed
the
fix/decouple-di-dc
branch
from
January 10, 2025 21:48
2499221
to
52b3f33
Compare
RanbirAulakh
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: n/a
Notes
Decoupling the DI and DC stacks as it will greatly increase stack deployment / destruction speeds and they are not being integrated for testing right now. We can reconnect them later again when required.
Testing
Before you submit a pull request, please make sure you have to following:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.