Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Car Tweaks #66

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Conversation

larsll
Copy link
Contributor

@larsll larsll commented Oct 26, 2024

Issue #, if available:

Description of changes:
These fixes will make the following changes to the cars:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@larsll larsll marked this pull request as ready for review October 26, 2024 15:42
@larsll
Copy link
Contributor Author

larsll commented Oct 28, 2024

@marcobuss @esbjj @StevenAskwith I would strongly suggest to merge this in before re:Invent; the model load times will simplify life a lot, and enable more efficient model changes during 2 minute runs.

@StevenAskwith
Copy link
Contributor

@larsll most of the team in on holiday this week, will review next week, but the idea looks good!

StevenAskwith added a commit to StevenAskwith/guidance-for-aws-deepracer-event-management that referenced this pull request Nov 4, 2024
@MarkRoss-Eviden
Copy link

Hi @StevenAskwith FYI as part of clarification questions for the finals we've asked if this functionality will be available. As you can imagine with limited practice (2 hour slot for 16 competitors on the Tues and Weds before round 1) and the limited time per racer in all rounds (2 min attempts) it's quite material whether changing models mid run takes ~45s or 2s.

@StevenAskwith
Copy link
Contributor

@MarkRoss-Eviden I triggered the deploy to my test environment ~30 mins ago, will update after I've tested.

@StevenAskwith StevenAskwith merged commit f64b4ef into aws-solutions-library-samples:main Nov 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants