Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not require public-read acl #13

Open
wants to merge 1 commit into
base: fargate
Choose a base branch
from
Open

Do not require public-read acl #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions bin/deploy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ zip deploy/templates.zip ecs-blue-green-deployment.yaml templates/*
cd scripts && zip scripts.zip * && cd ..
mv scripts/scripts.zip deploy/scripts.zip

aws s3 cp deploy/templates.zip "s3://${bucket}" --acl public-read
aws s3 cp deploy/scripts.zip "s3://${bucket}" --acl public-read
aws s3 cp ecs-blue-green-deployment.yaml "s3://${bucket}" --acl public-read
aws s3 cp --recursive templates/ "s3://${bucket}/templates" --acl public-read
aws s3 cp --recursive scripts/ "s3://${bucket}/scripts" --acl public-read
aws s3 cp deploy/templates.zip "s3://${bucket}"
aws s3 cp deploy/scripts.zip "s3://${bucket}"
aws s3 cp ecs-blue-green-deployment.yaml "s3://${bucket}"
aws s3 cp --recursive templates/ "s3://${bucket}/templates"
aws s3 cp --recursive scripts/ "s3://${bucket}/scripts"
aws s3api put-bucket-versioning --bucket "${bucket}" --versioning-configuration Status=Enabled
aws cloudformation deploy --stack-name $stackname --template-file ecs-blue-green-deployment.yaml --capabilities CAPABILITY_NAMED_IAM --parameter-overrides GitHubUser=$GitHubUser GitHubToken=$GitHubToken TemplateBucket=$bucket
5 changes: 4 additions & 1 deletion templates/deployment-pipeline.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,10 @@ Resources:
- ec2:*
- elasticloadbalancing:*
- autoscaling:*

- Resource: !Sub arn:aws:s3:::${TemplateBucket}/*
Effect: Allow
Action:
- s3:GetObject
CodeBuildServiceRole:
Type: AWS::IAM::Role
Properties:
Expand Down