Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kb-bot-embedding-titan-model-v1 to v2 #544

Merged
merged 2 commits into from
Sep 24, 2024
Merged

kb-bot-embedding-titan-model-v1 to v2 #544

merged 2 commits into from
Sep 24, 2024
+16 −16

Conversation

Tsujiba
Copy link
Contributor

@Tsujiba Tsujiba commented Sep 21, 2024

*Issue #543

Description of changes:

  • 'titan_v1' change to 'titan_v2' in each files.
  • BedrockFoundationModel.TITAN_EMBED_TEXT_V2_1024 use in bedrock-knowledge-base-args.ts

@statefb statefb self-requested a review September 24, 2024 01:18
statefb
statefb reviewed Sep 24, 2024
View reviewed changes
Copy link
Contributor

@statefb statefb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tsujiba
Thank you for your suggestion! Please replace some titan_v1 values in test script: test_custom_bot.py.
Other than above, LGTM!

@Tsujiba
Copy link
Contributor Author

Tsujiba commented Sep 24, 2024 •
edited
Loading

@statefb
Thank you for your review !

Please replace some titan_v1 values in test script: test_custom_bot.py

I have completed the above. Please check.

@statefb statefb merged commit cd9e3c6 into aws-samples:v1 Sep 24, 2024
6 checks passed
@statefb
Copy link
Contributor

statefb commented Sep 24, 2024

LGTM!

@Tsujiba Tsujiba deleted the feat/kb-embeddingmodel-titan-v2 branch October 19, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@statefb statefb statefb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tsujiba @statefb