Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic Publishing of Docker Images To Git Registry #90

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mdvertola
Copy link

Issue #, if available: N/A

Description of changes:
Adding a github workflow that builds and uploads the gateway and gateway-ecs images on merges to main to the github container registry.

Important call-outs to this PR:

  • since this repo does not appear to currently be using any versioning I configured to trigger on pushes/merges to main. For the same reason, i am tagging the images with the first several letters of their commit hash so they can be easily tracked to a point in time. (referred to as SHORT_SHA)
  • we build two images on each merge to main: SHORT_SHA and SHORT_SHA-ecs
  • can certainly be done with aws ecr but i figured this would be the shortest path to getting published container images as we will inherit github organization permissions to access the registry for upload vs managing aws credentials or docker credentials for ECR/DockerHub respectively.

Other:
if this is already published somewhere please add to docs! I luckily only took a short side step here to make this happen since i had a lot of the workflow file sitting around from other projects and know the eco system well but i am sure this could create a lot of friction/ poor DX for those not as familiar.

All in all though thanks for the work here in building this, seems to be a rock solid implementation and hope that the more i use it, the more I can contribute! Cheers to you guys for this.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant