Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enables opt-in region for guardduty logging #1222

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

rjjaegeraws
Copy link
Contributor

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

When configuring ca-west-1 the export configuration fails because service principal does not have permissions to write to the central log archive bucket and KMS Key. This Pull Request adds additional logic to support opt-in region service principals.

Copy link
Collaborator

@archikierstead archikierstead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@archikierstead archikierstead merged commit 2102ceb into aws-samples:main Apr 11, 2024
6 checks passed
@rjjaegeraws rjjaegeraws deleted the guardduty_optin_region branch April 11, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants