Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong argument passed to the updateTerminationProtection function #1197

Conversation

vic614
Copy link
Contributor

@vic614 vic614 commented Nov 16, 2023

The updateTerminationProtection function is getting a wrong argument "stack.id" which resulting the termination protection for stack not lifted and deletion of stack fail.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

The updateTerminationProtection function is getting a wrong argument "stack.id" which resulting the termination protection for stack not lifted and deletion of stack fail.
Copy link
Contributor

@rjjaegeraws rjjaegeraws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@vic614 vic614 changed the title Fix wrong argument passed to updateTerminationProtection function Fix wrong argument passed to the updateTerminationProtection function Nov 17, 2023
@vic614
Copy link
Contributor Author

vic614 commented Nov 28, 2023

@archikierstead could you please merge this for the next release?

@archikierstead archikierstead merged commit f93a132 into aws-samples:main Nov 30, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants