-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] feat(frontend): replace Reach Router v1 to React Router v6 #60
Draft
trivikr
wants to merge
13
commits into
main
Choose a base branch
from
use-react-router
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
changed the title
[WIP] chore(frontend): replace Reach Router v1 to React Router v6
[WIP] feat(frontend): replace Reach Router v1 to React Router v6
Nov 15, 2021
React Router v6.3.0 makes migration easier remix-run/react-router#8753 |
trivikr
force-pushed
the
use-react-router
branch
from
August 26, 2022 21:45
e8c810c
to
5d1981a
Compare
trivikr
force-pushed
the
use-react-router
branch
from
August 26, 2022 22:25
4d7df84
to
19b4016
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes: #26
Description
Switches from Reach Router v1 to React Router v6.
Testing
ToDo: Verify that routes work in the frontend.
Additional context
Refs: https://reactrouter.com/docs/en/v6/upgrading/reach#first-non-breaking-updates
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.