Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Umbrella project #2

Open
madshargreave opened this issue Jan 8, 2019 · 4 comments
Open

Umbrella project #2

madshargreave opened this issue Jan 8, 2019 · 4 comments

Comments

@madshargreave
Copy link

Does this work with umbrella projects?

@BradleyLyman
Copy link
Contributor

I haven't personally used it as an umbrella project.
It's a reasonable thought though. Especially given that this repo includes the examples as separate Mix projects (e.g. this repo is essentially an informal umbrella project consisting of the runtime and examples).

That said, is there something specific about an umbrella project that would be useful to support?
So far I've been able to leverage the runtime by declaring a normal Hex dependency in my mix file.

@madshargreave
Copy link
Author

One thing I noticed with regards to umbrella projects was that we use the name of the root mix project to create the folder structure in the bootstrap script.

To my knowledge the root mix project usually don't have the :app key, so this will always be null. If you then just set it to something, then you won't be able to deploy multiple different releases from the same project. The solution would be to use the name of the release instead

@BradleyLyman
Copy link
Contributor

Oh! I see, you're referring to this bit:

name =
Mix.Project.config()
|> Keyword.fetch!(:app)
|> to_string

That's an excellent point and it shouldn't be terribly hard to use the release instead.
Feel free to make a Pull Request if you've got something in mind :) Otherwise I'll make the change, test it, and see what it looks like sometime in the next few days.

@madshargreave
Copy link
Author

Yes exactly, I won't have time this this, but if you haven't looked at it before the following week I'll submit a PR 👍

carstenpiepel added a commit to carstenpiepel/aws-lambda-elixir-runtime that referenced this issue Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants