Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compliant and noncompliant examples of python/[email protected] #79

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add compliant and noncompliant examples of python/[email protected] #79

wants to merge 5 commits into from

Conversation

ankit-amazon
Copy link
Contributor

Description of changes:

linghuiluo
linghuiluo reviewed May 9, 2023
View reviewed changes
.../detectors/notebook_invalid_execution_order/notebook_invalid_execution_order_compliant.ipynb Outdated
"outputs": [],
"source": [
"# {fact [email protected] defects=0}\n",
"# Compliant: execution order of cells is valid.\n",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is linear.

linghuiluo
linghuiluo reviewed May 9, 2023
View reviewed changes
...tectors/notebook_invalid_execution_order/notebook_invalid_execution_order_noncompliant.ipynb Outdated
"outputs": [],
"source": [
"# {fact [email protected] defects=0}\n",
"# Noncompliant: execution order of cells is invalid.\n",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

execution order of cells is not linear. When executing cells in linear order, variables x and y are undefined before use.

san2488
san2488 requested changes May 15, 2023
View reviewed changes
Copy link
Contributor

@san2488 san2488 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detector Library only supports .py files

@linghuiluo
Copy link

looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linghuiluo linghuiluo linghuiluo left review comments

@san2488 san2488 san2488 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ankit-amazon @linghuiluo @san2488