Update fluent-bit to latest #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest is current 2.23.0. Version 2.10.0 is outdated.
| @@ -464,7 +464,7 @@ spec: | |||
| spec: | |||
| containers: | |||
| - name: fluent-bit | |||
| image: amazon/aws-for-fluent-bit:2.10.0 | |||
| image: amazon/aws-for-fluent-bit:latest | |||
There was a problem hiding this comment.
Personally, I think we need a good way to continuously test/verify the daemonsets before I'd be comfortable switching to use the latest tagged image. AFAIK tests for container insights only really happen when ramping up for a release of the agent, so I'd like to have proper integration testing set up prior to approving and merging this in. Whether it happens on this repo or the CloudWatch agent repo, I'm indifferent, but I did cut an issue in the CloudWatch agent repo to at least document this somewhere.
|
I think #95 is the better approach to pin to a release that is declared as stable rather than the latest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest is current 2.23.0. Version 2.10.0 is outdated.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.