Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IR] Implementation of QoS Features #1

Closed
wants to merge 19 commits into from
Closed

[IR] Implementation of QoS Features #1

wants to merge 19 commits into from

Commits on Mar 15, 2019

  1. Add interfaces for events in memory_strategy

    Signed-off-by: Miaofei <[email protected]>
    ross-desmond authored and mm318 committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    065a966 View commit details
    Browse the repository at this point in the history
  2. refactor waitables

    Signed-off-by: Miaofei <[email protected]>
    mm318 committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    6ddded4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a078e8e View commit details
    Browse the repository at this point in the history
  4. fix some ros2 build issues

    Signed-off-by: Miaofei <[email protected]>
    mm318 committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    1a4ccaa View commit details
    Browse the repository at this point in the history
  5. update client-facing API

    Signed-off-by: Miaofei <[email protected]>
    mm318 committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    e1ad5c2 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    cc8bb54 View commit details
    Browse the repository at this point in the history
  7. Attempt to fix cppcheck (ros2#646)

    Signed-off-by: Shane Loretz <[email protected]>
    Signed-off-by: Miaofei <[email protected]>
    sloretz authored and mm318 committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    afca6f4 View commit details
    Browse the repository at this point in the history
  8. Add a method to the LifecycleNode class to get the logging interface (r…

    …os2#652)
    
    There are getters for the other interfaces, but the logging interface
    appears to have been overlooked.
    
    Signed-off-by: Michael Jeronimo <[email protected]>
    Signed-off-by: Miaofei <[email protected]>
    Michael Jeronimo authored and mm318 committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    ec4476e View commit details
    Browse the repository at this point in the history
  9. update to use separated action types (ros2#601)

    * match renamed action types
    
    * fix action type casting
    
    * rename type/field to use correct term
    
    * rename custom GoalID type to avoid naming collision, update types using unique_identifier_msgs
    
    * remove obsolete comments
    
    * change signature of set_succeeded / set_canceled
    
    * change signature of     on_terminal_state_(uuid_, result_msg);set_succeeded / set_canceled
    
    * change signature of set_aborted
    
    * change signature of publish_feedback
    
    * update another test
    
    Signed-off-by: Miaofei <[email protected]>
    hidmic authored and mm318 committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    40ba3c6 View commit details
    Browse the repository at this point in the history
  10. Add Doxyfile for rclcpp_action

    Signed-off-by: Jacob Perron <[email protected]>
    Signed-off-by: Miaofei <[email protected]>
    jacobperron authored and mm318 committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    6821fa6 View commit details
    Browse the repository at this point in the history
  11. Add documentation to rclcpp_action

    Signed-off-by: Jacob Perron <[email protected]>
    Signed-off-by: Miaofei <[email protected]>
    jacobperron authored and mm318 committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    b7cdf8f View commit details
    Browse the repository at this point in the history
  12. Don't hardcode int64_t for duration type representations (ros2#648)

    In LLVM's `libcxx`, `int64_t` doesn't match chrono literals. See example below. To compile, run  `clang++-6.0 -stdlib=libc++ -std=c++14 TEST.cpp`
    
    ```
    using namespace std::chrono_literals;
    
    template<typename RatioT = std::milli>
    bool
    wait_for_service(
       std::chrono::duration<int64_t, RatioT> timeout
    )
    {
       return timeout == std::chrono::nanoseconds(0);
    }
    
    int main() {
       wait_for_service(2s);
       return 0;
    }
    
    ```
    
    Result of compilation
    ```
    TEST.cpp:6:1: note: candidate template ignored: could not match 'long' against 'long long'
    wait_for_service(
    ```
    
    Signed-off-by: Emerson Knapp <[email protected]>
    Signed-off-by: Steven! Ragnarök <[email protected]>
    Signed-off-by: Miaofei <[email protected]>
    emersonknapp authored and mm318 committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    22a6484 View commit details
    Browse the repository at this point in the history
  13. Fix test_time_source test (ros2#639)

    * Fix flakey test
    
    Signed-off-by: Pete Baughman <[email protected]>
    
    * Fix lint and uncrustify issues
    
    Signed-off-by: Pete Baughman <[email protected]>
    Signed-off-by: Miaofei <[email protected]>
    pbaughman authored and mm318 committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    80e3d48 View commit details
    Browse the repository at this point in the history
  14. fix lint errors

    Signed-off-by: Miaofei <[email protected]>
    mm318 committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    bcabadc View commit details
    Browse the repository at this point in the history
  15. apply uncrustify

    Signed-off-by: Miaofei <[email protected]>
    mm318 committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    993788f View commit details
    Browse the repository at this point in the history
  16. fix wait for service memory leak bug (ros2#656)

    * when call wait for service in an while loop, the event will be make forever and never release
    * fix it by: creating it when we need
    
    Signed-off-by: reed-lau <[email protected]>
    Signed-off-by: Miaofei <[email protected]>
    mm318 committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    a77d110 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2019

  1. Merge remote-tracking branch 'upstream/master' into qos

    Signed-off-by: Emerson Knapp <[email protected]>
    Emerson Knapp committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    8d94f1b View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2019

  1. update for rcl API changes

    Signed-off-by: Miaofei <[email protected]>
    mm318 committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    787fa6f View commit details
    Browse the repository at this point in the history
  2. Fix lint and build warnings and API inconsistency

    Signed-off-by: Emerson Knapp <[email protected]>
    Emerson Knapp committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    71ba5f3 View commit details
    Browse the repository at this point in the history