Fix lint and build warnings and API inconsistency

Signed-off-by: Emerson Knapp <[email protected]>
aws-ros-dev · Mar 21, 2019 · 71ba5f3 · 71ba5f3
1 parent 787fa6f
commit 71ba5f3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/rclcpp/include/rclcpp/publisher_options.hpp b/rclcpp/include/rclcpp/publisher_options.hpp
@@ -96,7 +96,7 @@ class PublisherOptions
    */
   RCLCPP_PUBLIC
   PublisherOptions &
-  publisher_qos_profile(const rmw_qos_profile_t & publisher_qos_profile)
+  qos_profile(const rmw_qos_profile_t & publisher_qos_profile)
   {
     publisher_qos_profile_ = publisher_qos_profile;
     return *this;
@@ -188,6 +188,7 @@ class PublisherOptions
   allocator(std::shared_ptr<Alloc> allocator)
   {
     allocator_ = allocator;
+    return *this;
   }
 
 private:

diff --git a/rclcpp/include/rclcpp/subscription_options.hpp b/rclcpp/include/rclcpp/subscription_options.hpp
@@ -160,6 +160,7 @@ class SubscriptionOptions
     return *this;
   }
 
+
   RCLCPP_PUBLIC
   const SubscriptionEventCallbacks &
   event_callbacks() const
@@ -196,6 +197,7 @@ class SubscriptionOptions
   allocator(std::shared_ptr<Alloc> allocator)
   {
     allocator_ = allocator;
+    return *this;
   }
 
 private: