Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #531 #532

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Conversation

bnaydenov
Copy link
Contributor

Fix for issue #531

*Adding missing IAM policy. Check the issue #531 for more details *

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@bnaydenov bnaydenov requested review from aws-ia-ci and a team as code owners November 3, 2022 21:14
@bnaydenov
Copy link
Contributor Author

@shapirov103 please check this one.

Copy link
Collaborator

@shapirov103 shapirov103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bnaydenov thank you for your contribution!

We will improve the validation framework. Apparently after switching to Karpenter we lost a test case to make sure cluster autoscaler works.

@shapirov103
Copy link
Collaborator

I will publish 1.4.1 shortly - planning tomorrow, unless more issue are discovered.

@shapirov103 shapirov103 merged commit bab3661 into aws-quickstart:main Nov 3, 2022
@bnaydenov
Copy link
Contributor Author

@shapirov103 thanks for quick reaction. I hope for no more issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants