-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix env variable name in logEventIfEnabled()
docstring
#3197
docs: fix env variable name in logEventIfEnabled()
docstring
#3197
Conversation
…ogger.logEventIfEnabled; fixes aws-powertools#3196
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
Quality Gate passedIssues Measures |
logEventIfEnabled()
docstring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kevinpeno, thank you so much for the quick PR in response to the issue.
Before I merge this, could you please leave a comment under the issue so I can assign it to you? It's just for tracking purposes and GitHub doesn't allow me to assign issues to external contributors unless they have interacted with the issue.
Thank you again for helping improving the project!
No problem! I was looking for some easy wins this morning and came across that issue. Glad I could help! |
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Summary
fix typo for env variable POWERTOOLS_LOGGER_LOG_EVENT in logger.logEventIfEnabled
Changes
Fixed env details on typedoc for
logger.logEventIfEnabled
fromPOWERTOOLS_LOG_EVENT
toPOWERTOOLS_LOGGER_LOG_EVENT
per discussion in #3196Issue number: #3196
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.