Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(idempotency): switch e2e tests to vitest #3149

Merged
merged 6 commits into from
Oct 3, 2024

Conversation

dreamorosi
Copy link
Contributor

Summary

Changes

Please provide a summary of what's being changed

This PR updates the configuration of the e2e tests for the Idempotency package so that they use Vitest instead of Jest.

I have run the integration tests using the new runner for this package and confirmed that they work.

The PR is quite small since most of the migration for the package was already addressed in a previous PR.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #3147


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Oct 2, 2024
@dreamorosi dreamorosi requested review from a team as code owners October 2, 2024 14:47
@boring-cyborg boring-cyborg bot added dependencies Changes that touch dependencies, e.g. Dependabot, etc. tests PRs that add or change tests labels Oct 2, 2024
@pull-request-size pull-request-size bot added the size/L PRs between 100-499 LOC label Oct 2, 2024
Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @dreamorosi! Just a few suggestions to keep some consistency in the texts, but it's approved.

Co-authored-by: Leandro Damascena <[email protected]>
dreamorosi and others added 3 commits October 3, 2024 02:03
Copy link

sonarqubecloud bot commented Oct 3, 2024

Copy link

sonarqubecloud bot commented Oct 3, 2024

@dreamorosi dreamorosi merged commit c97d379 into main Oct 3, 2024
21 checks passed
@dreamorosi dreamorosi deleted the chore/vitest_idempotency_e2e branch October 3, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changes that touch dependencies, e.g. Dependabot, etc. size/L PRs between 100-499 LOC tests PRs that add or change tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: migrate idempotency e2e tests to vitest
2 participants