-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(parameters): adds setParameter function to store SSM parameters #3020
feat(parameters): adds setParameter function to store SSM parameters #3020
Conversation
Hi @daschaa, thank you for the PR! I'll start reviewing it by tomorrow end of the day at the latest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @daschaa, thank you for the patience while I reviewed the PR.
High quality as usual, just left some minor comments - looking forward to merge this!
@dreamorosi Thanks for the review, I think I have covered everything :) |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this PR, @daschaa!
I appreciate the time you've put into this, both in the initial implementation and subsequent iterations.
I also ran the end to end tests and they were green 🎉
@leandrodamascena, @sthulb, @am29d - if either of you see this, please feel free to approve & merge this. I had to do a couple of touch ups in the form of suggestions and I can't merge it myself because I'm the last one to have committed. Thanks! |
Summary
Implements the
setParameter
functionality. Closes #2871Changes
With this change the
SSMProvider
is extended to have aset
method that allows to pass in aname
and anoptions
object.In the
options
thevalue
property is mandatory to set a value. Along with the value there are multiple properties that were suggested here.The docstring for this method is mainly copy, pasted and adjusted from the
get
method in the same class.Additional to the implementation in the
SSMProvider
, asetParameter
function has been implemented and export via the barrel file. It supports the same structure like theset
method of theSSMProvider
class.The docstring is also mainly copy, pasted and adjusted from the
getParameter
function.There is also a section added to the documentation in the
docs
folder for storing parameters withsetParameter
. I decided to include an basic example and one example for overwriting a parameter value (because this was something I experienced myself in the past, that I need the overwrite flag and I thought this might be a handy example).Please let me know if i should adjust the documentation and/or add stuff. I tried to keep everything basic and extend later on after the review.
Open topics
doc
folder if something needs to be adjustedIssue number: #2871
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.