Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(maintenance): replace copy command in docs dockerfile #2911

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

dreamorosi
Copy link
Contributor

@dreamorosi dreamorosi commented Aug 12, 2024

Summary

Changes

Please provide a summary of what's being changed

This PR replaces usage of the ADD command in the docs Dockerfile with the more straightforward, and according to SonarCloud, better COPY.

See the linked issue for full explanation provided by SonarCloud.

Note that I have tested the change locally by rebuilding the image with the updated Dockerfile and verified that the docs build & run successfully.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #2910


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Aug 12, 2024
@dreamorosi dreamorosi requested review from a team as code owners August 12, 2024 10:10
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Aug 12, 2024
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Aug 12, 2024
Copy link

Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVED!

docs/Dockerfile Show resolved Hide resolved
@dreamorosi dreamorosi merged commit d208b2c into main Aug 12, 2024
16 checks passed
@dreamorosi dreamorosi deleted the chore/update_docker_cmd branch August 12, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: replace usage of ADD in docs Dockerfile
2 participants