Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create event-handler utility workspace #2858

Merged
merged 8 commits into from
Jul 30, 2024

Conversation

dreamorosi
Copy link
Contributor

Summary

Changes

Please provide a summary of what's being changed

This PR adds the event-handler utility to the project's workspace.

This is done by:

  • creating a new folder under packages/event-handler
  • initializing the package via npm init -w packages/event-handler
  • filling in the package.json created in the new folder
  • adding the various config files (i.e tsconfig.json, jest.config.cjs, etc.)
  • adding utility doc page (first draft)
  • adding utility readme file (first draft)
  • add "work in progress" notices
  • add utility to lerna.json as well as other CI workflows

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #2857


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Jul 29, 2024
@dreamorosi dreamorosi requested review from a team as code owners July 29, 2024 18:34
@boring-cyborg boring-cyborg bot added automation This item relates to automation dependencies Changes that touch dependencies, e.g. Dependabot, etc. documentation Improvements or additions to documentation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) labels Jul 29, 2024
@pull-request-size pull-request-size bot added the size/L PRs between 100-499 LOC label Jul 29, 2024
@dreamorosi dreamorosi changed the title chore(event-handler): create utility workspace chore: create utility workspace Jul 29, 2024
@dreamorosi dreamorosi changed the title chore: create utility workspace chore: create event-handler utility workspace Jul 29, 2024
Copy link
Contributor

@am29d am29d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor typo.

We should add the package to beta list in our workflow script, so we can avoid accidental releases:

.github/boring-cyborg.yml Outdated Show resolved Hide resolved
@dreamorosi
Copy link
Contributor Author

@am29d - thanks for the review & suggestion.

The package was already set as private in its package.json file - however it's true I forgot to add it to the script. I've now added it to the alpha group.

@dreamorosi dreamorosi requested a review from am29d July 30, 2024 07:20
Copy link

@am29d am29d merged commit 5982f50 into main Jul 30, 2024
11 checks passed
@am29d am29d deleted the chore/create_evt_handler_workspace branch July 30, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation dependencies Changes that touch dependencies, e.g. Dependabot, etc. documentation Improvements or additions to documentation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) size/L PRs between 100-499 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: create event-handler workspace
2 participants