Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(maintenance): migrate parameters utility to biome #2812

Merged
merged 6 commits into from
Jul 23, 2024

Conversation

dreamorosi
Copy link
Contributor

Summary

Changes

Please provide a summary of what's being changed

This PR migrates the linting and formatting of the Batch Processing utility to use Biome instead of a combination of Eslint and Prettier.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #2800


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Jul 23, 2024
@dreamorosi dreamorosi requested review from a team as code owners July 23, 2024 12:04
@boring-cyborg boring-cyborg bot added dependencies Changes that touch dependencies, e.g. Dependabot, etc. parameters This item relates to the Parameters Utility tests PRs that add or change tests labels Jul 23, 2024
@pull-request-size pull-request-size bot added the size/L PRs between 100-499 LOC label Jul 23, 2024
am29d
am29d previously approved these changes Jul 23, 2024
@dreamorosi
Copy link
Contributor Author

Sorry for the double reviews @am29d, I had to fix a couple of Sonar things both here & in the other #2809.

They should both be ready now.

Copy link

@dreamorosi dreamorosi merged commit abd3832 into main Jul 23, 2024
10 checks passed
@dreamorosi dreamorosi deleted the chore/biome_parameters branch July 23, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changes that touch dependencies, e.g. Dependabot, etc. parameters This item relates to the Parameters Utility size/L PRs between 100-499 LOC tests PRs that add or change tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: add biome to project (parameters)
2 participants