chore(ci): revert enable CodeQl (#2731) #2740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d76eb1d.
am29d
previously approved these changes
Jul 9, 2024
|
am29d
approved these changes
Jul 9, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This reverts commit d76eb1d.
After enabling CodeQL I realized that it was misconfigured and that it was running not only on source files but also on the built outputs (i.e.
packages/logger/lib/cjs/*).Additionally, the SonarCloud team has stated that they might reconsider enabling analysis of PRs coming from forks, and that a decision should come by middle of this week.
Because of these two points, I'm reverting the PR. We might reconsider adding CodeQL back in the next iteration if SonarCloud does not get fixed, or a fix is not available for us.
Issue number: #2730
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.