Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): update post release workflow #1506

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

This PR aims at fixing the issue described in the linked PR that caused the workflow in charge of leaving a comment & labelling issues related to a release to fail the operation.

Aside from formatting, the changes involve making sure that when the script is running (upon new release) it's considering only closed issues that were labeled as status/pending-release. The other main change, that should fix the issue, however involves fixing a bug around how the existing labels were filtered and merged with the new ones.

Related issues, RFCs

Issue number: #1493

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Jun 16, 2023
@dreamorosi dreamorosi linked an issue Jun 16, 2023 that may be closed by this pull request
2 tasks
@boring-cyborg boring-cyborg bot added the automation This item relates to automation label Jun 16, 2023
@pull-request-size pull-request-size bot added the size/L PRs between 100-499 LOC label Jun 16, 2023
@dreamorosi dreamorosi merged commit 3312019 into main Jun 16, 2023
@dreamorosi dreamorosi deleted the dreamorosi/issue1493 branch June 16, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation size/L PRs between 100-499 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: fix post-release workflow
1 participant