Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): added back s3 bucket to workflow #1505

Merged
merged 1 commit into from
Jun 16, 2023
Merged

chore(docs): added back s3 bucket to workflow #1505

merged 1 commit into from
Jun 16, 2023

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

This is a followup PR to #1494 that adds back a missing line to the workflow that publishes the docs to the new S3 destination. The workflow was failing because of this missing line.

Related issues, RFCs

Issue number: #1490

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Jun 16, 2023
@boring-cyborg boring-cyborg bot added the automation This item relates to automation label Jun 16, 2023
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Jun 16, 2023
@dreamorosi dreamorosi merged commit 6fe47ee into main Jun 16, 2023
@dreamorosi dreamorosi deleted the chore/docs branch June 16, 2023 10:44
@dreamorosi dreamorosi linked an issue Jun 16, 2023 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: fix beta docs publishing
1 participant