-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(idempotency): API docs for idempotency #1485
docs(idempotency): API docs for idempotency #1485
Conversation
…son config is depricated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Alex, thanks for the great work - I appreciate that you took the time to improve the API docs for the whole project and standardized the configs!
I have left a few comments, mostly minor ones, except one related to the imports and exports. See more details below - happy to discuss it further later if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work with this PR, the new docs are looking nice.
I think we should include the BaseProvider
class for Parameters (so that customers can extend it and build their own provider) and check that DynamoDBPersistenceLayer
is included in the exports - but we'll do it in separate PRs.
Description of your changes
entryPoints
for each packageRelated issues, RFCs
Issue number: #1104
Checklist
Breaking change checklist
Is it a breaking change?: NO
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.