Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add workflow to dispatch analytics fetching #1418

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

rubenfonseca
Copy link
Contributor

@rubenfonseca rubenfonseca commented Apr 25, 2023

Description of your changes

This PR adds a new GitHub action workflow that runs every hour, and uses the GITHUB_TOKEN to dispatch the crawling of the analytics data.

How to verify this change

In order to merge this we'll need:

  • create a new GitHub environment called "analytics"
  • inside that new environment, create two new secrets (please contact me on Slack for the values):
    • AWS_ANALYTICS_ROLE_ARN
    • AWS_ANALYTICS_DISPATCHER_ARN

After this, the PR can be merged, and will close #1419.

Related issues, RFCs

Issue number: #1419

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@pull-request-size pull-request-size bot added the size/M PR between 30-99 LOC label Apr 25, 2023
@github-actions github-actions bot added the internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) label Apr 25, 2023
@rubenfonseca rubenfonseca marked this pull request as ready for review April 25, 2023 09:42
@dreamorosi dreamorosi self-requested a review April 25, 2023 09:48
@dreamorosi dreamorosi changed the title chore: add workflow to dispatch analytics fetching chore(ci): add workflow to dispatch analytics fetching Apr 25, 2023
@dreamorosi
Copy link
Contributor

Added the secrets to the environment as described above, using the values shared on Slack

image

Let me know if it looks okay, if yes I'll approve and merge

@rubenfonseca
Copy link
Contributor Author

Looks good! Ready to merge

@dreamorosi dreamorosi merged commit 2076486 into main Apr 25, 2023
@dreamorosi dreamorosi deleted the rf/dispatch-analytics branch April 25, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) size/M PR between 30-99 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: introduce reporting workflow
2 participants