Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): updated layer info #1358

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

As discussed in the linked issue, at the moment users opting for using the Lambda Layers published by Powertools didn't have clear instructions on how to deal with their local environment and dependencies. While this might be obvious for more experienced developers, there might be some customers that need a refresher, so this PR adds a section that clarifies this.

This PR closes #1357.

How to verify this change

See rendered

Related issues, RFCs

Issue number: #1357

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Mar 8, 2023
@dreamorosi dreamorosi linked an issue Mar 8, 2023 that may be closed by this pull request
1 task
@pull-request-size pull-request-size bot added the size/S PR between 10-29 LOC label Mar 8, 2023
@github-actions github-actions bot added the internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) label Mar 8, 2023
@dreamorosi dreamorosi merged commit 1168066 into main Mar 8, 2023
@dreamorosi dreamorosi deleted the 1357-docs-improve-messaging-around-lambda-layer branch March 8, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) size/S PR between 10-29 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: improve messaging around Lambda layer
1 participant