Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(logger): revisited integration tests #1342

Merged
merged 4 commits into from
Feb 27, 2023

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

This PR refactors the integration tests for Logger and once merged resolves #1330.

The main changes done are:

  • All tests now have 3+ invocations and assertions are done on each one of them, rather than only on the first 1-2
  • All tests follow the same main structure & conventions
  • Fixed a test in the child logger fixture that was not checking the values correctly and was always giving false positives

How to verify this change

See results of successful run here.

Related issues, RFCs

Issue number: #1330

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dreamorosi dreamorosi self-assigned this Feb 27, 2023
@dreamorosi dreamorosi linked an issue Feb 27, 2023 that may be closed by this pull request
2 tasks
@pull-request-size pull-request-size bot added the size/XL PRs between 500-999 LOC, often PRs that grown with feedback label Feb 27, 2023
@dreamorosi dreamorosi merged commit c99714f into main Feb 27, 2023
@dreamorosi dreamorosi deleted the 1330-maintenance-revisit-logger-integration-tests branch February 27, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL PRs between 500-999 LOC, often PRs that grown with feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: revisit logger integration tests
1 participant