Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fixed workflow dependencies #1333

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

#1324 introduced some changes to the workflows that publish layers and docs. Some of the changes included incorrect references in some of the jobs dependencies which weren't caught during review and showed up on the GitHub actions only after merging the PR (examples: 1, 2, 3).

Once merged this PR should close #1124.

How to verify this change

Merge the PR and see if there are additional errors.

Related issues, RFCs

Issue number: #1124

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published
  • The PR title follows the conventional commit semantics

Breaking change checklist

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dreamorosi dreamorosi self-assigned this Feb 26, 2023
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Feb 26, 2023
@dreamorosi dreamorosi merged commit 179fc27 into main Feb 26, 2023
@dreamorosi dreamorosi deleted the 1124-maintenance-publish-layers-increment-version-during-main-release-process branch February 26, 2023 01:19
@github-actions github-actions bot added the internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) label Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: publish layers & increment version during main release process
1 participant