refactor(parameters): moved ssm resource creation to AwsCustomResource
#1319
+25
−123
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
As described in the linked issue (#1316), as part of the integration tests for the
SSMProvider
part of the Parameters utility we are creating some SecureString SSM resources. The creation of this type of resources was initially implemented with a Lambda-backed custom resource because CDK doesn't offer any L2 construct for them.This PR refactor that portion of code to instead use
AwsCustomResource
. This allows to remove a significant amount of code and to not have to maintain a dedicated Lambda function whose single purpose was to create & delete these resources. With the usage ofAwsCustomResource
the responsibility of this function is moved to CDK instead.Once merged, this PR will close #1316.
How to verify this change
See successful e2e test run here.
Related issues, RFCs
Issue number: #1316
PR status
Is this ready for review?: YES
Is it a breaking change?: NO
Checklist
Breaking change checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.