Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(parameters): update package to run as part of e2e tests #1318

Merged

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

Now that all the integration tests for Parameters have been implemented, the utility can be added to the workflow that runs the e2e tests on GitHub.

This PR makes the changes necessary to run the tests part of this package once the run-e2e-tests.yml workflow is run and will close #1039 once merged.

How to verify this change

See integration test run here

Related issues, RFCs

Issue number: #1039

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published
  • The PR title follows the conventional commit semantics

Breaking change checklist

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dreamorosi dreamorosi self-assigned this Feb 21, 2023
@dreamorosi dreamorosi linked an issue Feb 21, 2023 that may be closed by this pull request
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Feb 21, 2023
@dreamorosi dreamorosi changed the title tests(parameters): update package.json to run e2e tests tests(parameters): update package to run as part of e2e tests Feb 21, 2023
@dreamorosi dreamorosi merged commit af280dc into main Feb 21, 2023
@dreamorosi dreamorosi deleted the 1039-maintenance-write-end-to-end-tests-for-the-utility branch February 21, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: write end-to-end tests for the utility
1 participant