Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(parameters): add comments to SecretsProvider e2e test #1282

Merged
merged 4 commits into from
Feb 9, 2023
Merged

tests(parameters): add comments to SecretsProvider e2e test #1282

merged 4 commits into from
Feb 9, 2023

Conversation

am29d
Copy link
Contributor

@am29d am29d commented Feb 8, 2023

Description of your changes

I have added a top comment in the e2e test file describing all the cases with setup and verification steps. I have also added a short guidance for future maintainers and contributors when adding new tests. Some of these pointers are generic, i.e. use dedicated resources for each test case. Others are more specific, i.e. we use custom function from CustomFile.ts to do X.

How to verify this change

Related issues, RFCs

Issue number: #1279

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published
  • The PR title follows the conventional commit semantics

Breaking change checklist

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pull-request-size pull-request-size bot added the size/L PRs between 100-499 LOC label Feb 8, 2023
@dreamorosi dreamorosi self-requested a review February 9, 2023 10:54
@dreamorosi dreamorosi added the tests PRs that add or change tests label Feb 9, 2023
dreamorosi
dreamorosi previously approved these changes Feb 9, 2023
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, just left one minor suggestion to fix a typo.

Other than that, it looks great!

@dreamorosi dreamorosi linked an issue Feb 9, 2023 that may be closed by this pull request
2 tasks
@dreamorosi dreamorosi merged commit ba921c1 into aws-powertools:main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L PRs between 100-499 LOC tests PRs that add or change tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: add comments to SecretsProvider integration tests
2 participants