-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(docs): apply eslint rules to code snippets #1259
refactor(docs): apply eslint rules to code snippets #1259
Conversation
Please review so that we can discuss about the TODOs as described in this PR comment:
// cc. @dreamorosi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a number of comments.
I think we are going in the right direction, maybe one/two more iterations and we'll get there.
Aside from the comments I have left, please also change the .github/workflows/reusable-run-linting-check-and-unit-tests.yml
file to add -w docs/snippets
:
Thanks!
@dreamorosi proposals applied with additional new commit. Note: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for opening this PR
@saragerion i think the What do you think ? @dreamorosi having background information from the beginning of this journey with extracting and linting code snippets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Niko, I'm now back at work and I was able to look at the captureAWSAll
code snippet.
I have proposed an alternative that works and shouldn't require any special override to the linting rules.
Whenever you can please apply this suggestion and resolve the merge conflicts. Looking forward to merge this and move on.
cc8d108
to
31ff7b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the work on this, I appreciate the effort you've put in it.
Description of your changes
root: true
in eslint configuration file in root of repository which manages the workspace.semi
,quotes
,indent
no-explicit-any
,no-unused-vars
,explicit-member-accessibility
,no-var-requires
,@aws-sdk/client-s3
defined as dev. dependency in package.json of docs/snippetsTODOs:
options / trade-offs, typescript linting issues for code snippets:
no-explicit-any
,no-unused-vars
,explicit-member-accessibility
,no-var-requires
How to verify this change
npm run -w docs/snippets lint -- --debug
should yield
npm run -w docs/snippets lint
Related issues, RFCs
Issue number: #1252 #729
PR status
Is this ready for review?: YES
Is it a breaking change?: NO
Checklist
Breaking change checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.