Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove httpbinorg request from integration tests #1194

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

As described in the linked issue, before this PR the integration tests were using httpbin.org as destination for some requests made during the Tracer tests.

This PR replaces that host with the base URL of the project's documentation to avoid reliance on 3rd party services.

How to verify this change

See test run of integration tests published in the comments below the PR.

Related issues, RFCs

Issue number: #1193

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published
  • The PR title follows the conventional commit semantics

Breaking change checklist

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dreamorosi dreamorosi linked an issue Dec 17, 2022 that may be closed by this pull request
2 tasks
@pull-request-size pull-request-size bot added the size/M PR between 30-99 LOC label Dec 17, 2022
@dreamorosi dreamorosi self-assigned this Dec 17, 2022
@github-actions github-actions bot added the internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) label Dec 17, 2022
@dreamorosi
Copy link
Contributor Author

@dreamorosi dreamorosi merged commit e744d43 into main Dec 17, 2022
@dreamorosi dreamorosi deleted the 1193-maintenance-remove-httpbinorg-request-from-integration-tests branch December 17, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) size/M PR between 30-99 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: remove httpbin.org request from integration tests
1 participant