Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added Node.js 12 deprecation banner to docs #1188

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

This PR introduces a banner at the top of the documentation website to inform customers that v1.5.0 will be the last version that supports Nodejs 12 and the nodejs12.x AWS Lambda runtime. While we don't have a date scheduled for the next release, I don't expect there to be any release before Jan 2023 (over 2weeks away).

In addition to the banner, I have left a longer comment in the linked issue and made an announcement on the Discord server, as well as Twitter.

How to verify this change

See docs local preview or published docs after merge.

Related issues, RFCs

Issue number: #1061

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published
  • The PR title follows the conventional commit semantics

Breaking change checklist

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Dec 13, 2022
@dreamorosi dreamorosi self-assigned this Dec 13, 2022
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 13, 2022
@dreamorosi dreamorosi merged commit f78c23f into main Dec 13, 2022
@dreamorosi dreamorosi deleted the chore/nodejs12_deprecation branch December 13, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant