Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(internal): remove unused test folder from project's root #1162

Merged
merged 2 commits into from
Nov 13, 2022

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

This PR removes the tests folder at the root level of the project and replaces its two usages (in the unit tests of two utilities) with the one from the commons package.

How to verify this change

See the results of the automated checks in the PR which should be passing.

Related issues, RFCs

Issue number: #1161

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

Breaking change checklist

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dreamorosi dreamorosi self-assigned this Nov 13, 2022
@github-actions github-actions bot added the internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) label Nov 13, 2022
@dreamorosi dreamorosi linked an issue Nov 13, 2022 that may be closed by this pull request
2 tasks
@dreamorosi dreamorosi merged commit 664c4da into main Nov 13, 2022
@dreamorosi dreamorosi deleted the chore/remove_unused_test_folder branch November 13, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Remove redundant tests folder from project's root
1 participant