Skip to content

Commit

Permalink
chore(parameters): fix code smells
Browse files Browse the repository at this point in the history
  • Loading branch information
dreamorosi committed Oct 20, 2023
1 parent 93e48e5 commit 8026e19
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 9 deletions.
4 changes: 0 additions & 4 deletions packages/parameters/src/appconfig/AppConfigProvider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,6 @@ import type {
AppConfigGetOptions,
AppConfigGetOutput,
} from '../types/AppConfigProvider';
/* import {
addUserAgentMiddleware,
isSdkClient,
} from '@aws-lambda-powertools/commons'; */

/**
* ## Intro
Expand Down
4 changes: 0 additions & 4 deletions packages/parameters/src/dynamodb/DynamoDBProvider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,6 @@ import type {
} from '@aws-sdk/client-dynamodb';
import type { PaginationConfiguration } from '@aws-sdk/types';
import type { JSONValue } from '@aws-lambda-powertools/commons';
/* import {
addUserAgentMiddleware,
isSdkClient,
} from '@aws-lambda-powertools/commons'; */

/**
* ## Intro
Expand Down
8 changes: 7 additions & 1 deletion packages/parameters/tests/unit/BaseProvider.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,13 @@ describe('Class: BaseProvider', () => {
class TestProvider extends BaseProvider {
public constructor() {
super({
proto: class {},
proto: class {
#name = 'TestProvider';

public hello(): string {
return this.#name;
}
},
});
}

Expand Down

0 comments on commit 8026e19

Please sign in to comment.