Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(event-handler): improve testing section for graphql #996

Merged
merged 4 commits into from
Feb 4, 2022

Conversation

to-mc
Copy link
Contributor

@to-mc to-mc commented Feb 3, 2022

Issue #, if available: #857

Description of changes:

Small improvements to "Testing Your Code" section in of graphql event handlers doc. Made example more relevant to a real application rather than borrowing our own example test, and added an example for async tests.

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.


View rendered docs/core/event_handler/appsync.md

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 3, 2022
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Feb 3, 2022
@to-mc to-mc requested a review from heitorlessa February 3, 2022 15:49
@heitorlessa heitorlessa changed the title docs: improve "testing your code" section for graphql event handler docs(event-handler): improve "testing your code" section for graphql Feb 3, 2022
Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better. Only change is to make sure we handle a file descriptor correctly in the sample test

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2022

Codecov Report

Merging #996 (5cf6517) into develop (168ec48) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #996   +/-   ##
========================================
  Coverage    99.96%   99.96%           
========================================
  Files          119      119           
  Lines         5347     5347           
  Branches       610      610           
========================================
  Hits          5345     5345           
  Partials         2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 168ec48...5cf6517. Read the comment docs.

@to-mc to-mc requested a review from heitorlessa February 4, 2022 10:44
@to-mc
Copy link
Contributor Author

to-mc commented Feb 4, 2022

Suggested change added!

@heitorlessa heitorlessa changed the title docs(event-handler): improve "testing your code" section for graphql docs(event-handler): improve testing section for graphql Feb 4, 2022
@heitorlessa heitorlessa merged commit b52b430 into develop Feb 4, 2022
@heitorlessa heitorlessa deleted the docs/async_testing_example branch February 4, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants