-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(event-handler): improve testing section for graphql #996
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much better. Only change is to make sure we handle a file descriptor correctly in the sample test
Codecov Report
@@ Coverage Diff @@
## develop #996 +/- ##
========================================
Coverage 99.96% 99.96%
========================================
Files 119 119
Lines 5347 5347
Branches 610 610
========================================
Hits 5345 5345
Partials 2 2 Continue to review full report at Codecov.
|
Suggested change added! |
Issue #, if available: #857
Description of changes:
Small improvements to "Testing Your Code" section in of graphql event handlers doc. Made example more relevant to a real application rather than borrowing our own example test, and added an example for async tests.
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
View rendered docs/core/event_handler/appsync.md