feat(feature_flags): Added inequality conditions #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area/utilities
documentation
pull-request-size
bot
added
the
size/L
|
@heitorlessa -- conflicts resolved. |
added 2 commits
October 1, 2021 13:42
Codecov Report
@@ Coverage Diff @@
## develop #721 +/- ##
========================================
Coverage 99.93% 99.93%
========================================
Files 116 116
Lines 4910 4914 +4
Branches 271 271
========================================
+ Hits 4907 4911 +4
Misses 1 1
Partials 2 2
Continue to review full report at Codecov.
|
|
@heitorlessa -- tests fixed. |
heitorlessa
suggested changes
Oct 3, 2021
There was a problem hiding this comment.
Thanks a lot again @gwlester - my only ask would be to merge these _1 and _2 tests so we reduce the number of imports that pytests have to make
Comment on lines
+859
to
+903
| def test_flags_less_than_no_match_1(mocker, config): | ||
| expected_value = False | ||
| mocked_app_config_schema = { | ||
| "my_feature": { | ||
| "default": expected_value, | ||
| "rules": { | ||
| "Date less than 2021.10.31": { | ||
| "when_match": True, | ||
| "conditions": [ | ||
| { | ||
| "action": RuleAction.KEY_LESS_THAN_VALUE.value, | ||
| "key": "current_date", | ||
| "value": "2021.10.31", | ||
| } | ||
| ], | ||
| } | ||
| }, | ||
| } | ||
| } | ||
| feature_flags = init_feature_flags(mocker, mocked_app_config_schema, config) | ||
| toggle = feature_flags.evaluate(name="my_feature", context={"tenant_id": "345345435", "username": "a", "current_date": "2021.12.25"}, default=False) | ||
| assert toggle == expected_value | ||
|
|
||
| def test_flags_less_than_no_match_2(mocker, config): | ||
| expected_value = False | ||
| mocked_app_config_schema = { | ||
| "my_feature": { | ||
| "default": expected_value, | ||
| "rules": { | ||
| "Date less than 2021.10.31": { | ||
| "when_match": True, | ||
| "conditions": [ | ||
| { | ||
| "action": RuleAction.KEY_LESS_THAN_VALUE.value, | ||
| "key": "current_date", | ||
| "value": "2021.10.31", | ||
| } | ||
| ], | ||
| } | ||
| }, | ||
| } | ||
| } | ||
| feature_flags = init_feature_flags(mocker, mocked_app_config_schema, config) | ||
| toggle = feature_flags.evaluate(name="my_feature", context={"tenant_id": "345345435", "username": "a", "current_date": "2021.10.31"}, default=False) | ||
| assert toggle == expected_value |
There was a problem hiding this comment.
perhaps merge them in a single test w/ different features?
There was a problem hiding this comment.
We could, but I always lean toward one test for one condition.
We were just bit by one test that was supposed to test several conditions and due to the complexity was not testing them but was still appearing to pass.
|
Fair enough
…On Sun, 3 Oct 2021 at 20:53, Gerald Leter ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tests/functional/feature_flags/test_feature_flags.py
<#721 (comment)>
:
> +def test_flags_less_than_no_match_1(mocker, config):
+ expected_value = False
+ mocked_app_config_schema = {
+ "my_feature": {
+ "default": expected_value,
+ "rules": {
+ "Date less than 2021.10.31": {
+ "when_match": True,
+ "conditions": [
+ {
+ "action": RuleAction.KEY_LESS_THAN_VALUE.value,
+ "key": "current_date",
+ "value": "2021.10.31",
+ }
+ ],
+ }
+ },
+ }
+ }
+ feature_flags = init_feature_flags(mocker, mocked_app_config_schema, config)
+ toggle = feature_flags.evaluate(name="my_feature", context={"tenant_id": "345345435", "username": "a", "current_date": "2021.12.25"}, default=False)
+ assert toggle == expected_value
+
+def test_flags_less_than_no_match_2(mocker, config):
+ expected_value = False
+ mocked_app_config_schema = {
+ "my_feature": {
+ "default": expected_value,
+ "rules": {
+ "Date less than 2021.10.31": {
+ "when_match": True,
+ "conditions": [
+ {
+ "action": RuleAction.KEY_LESS_THAN_VALUE.value,
+ "key": "current_date",
+ "value": "2021.10.31",
+ }
+ ],
+ }
+ },
+ }
+ }
+ feature_flags = init_feature_flags(mocker, mocked_app_config_schema, config)
+ toggle = feature_flags.evaluate(name="my_feature", context={"tenant_id": "345345435", "username": "a", "current_date": "2021.10.31"}, default=False)
+ assert toggle == expected_value
We could, but I always lean toward one test for one condition.
We were just bit by one test that was supposed to test several conditions
and due to the complexity was not testing them but was still appearing to
pass.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#721 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZPQBA3EKDCE527BYXGCYLUFCRDRANCNFSM5FE3RTHA>
.
|
heitorlessa
approved these changes
Oct 3, 2021
heitorlessa
added a commit
to heitorlessa/aws-lambda-powertools-python
that referenced
this pull request
Oct 5, 2021
…tools-python into develop * 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: feat(feature_flags): Added inequality conditions (aws-powertools#721) fix(feature-flags): rules should evaluate with an AND op (aws-powertools#724) fix(logger): push extra keys to the end (aws-powertools#722)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #701, if available:
Description of changes:
Added inequality conditions.
Checklist
Breaking change checklist
RFC issue #701:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
View rendered docs/utilities/feature_flags.md