Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(feature-flags): add debug for all features evaluation" #590

Merged
merged 2 commits into from
Aug 5, 2021
Merged

refactor(feature-flags): add debug for all features evaluation" #590

merged 2 commits into from
Aug 5, 2021

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented Aug 5, 2021 •
edited
Loading

Issue #, if available: #563

Description of changes:

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 5, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2021 •
edited
Loading

Codecov Report

Merging #590 (7a76582) into develop (f0a852a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #590   +/-   ##
========================================
  Coverage    99.95%   99.95%           
========================================
  Files          113      113           
  Lines         4533     4534    +1     
  Branches       245      245           
========================================
+ Hits          4531     4532    +1     
  Partials         2        2
Impacted Files Coverage Δ
...owertools/utilities/feature_flags/feature_flags.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0a852a...7a76582. Read the comment docs.

@pull-request-size pull-request-size bot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 5, 2021
@boring-cyborg boring-cyborg bot added the internal Maintenance changes label Aug 5, 2021
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 5, 2021
@heitorlessa heitorlessa changed the title chore(feature-flags): re-add debug log for all features evaluation" refactorfeature-flags): re-add debug log for all features evaluation" Aug 5, 2021
@heitorlessa heitorlessa changed the title refactorfeature-flags): re-add debug log for all features evaluation" refactor(feature-flags): re-add debug log for all features evaluation" Aug 5, 2021
@heitorlessa heitorlessa added the feature New feature or functionality label Aug 5, 2021
@heitorlessa heitorlessa added this to the 1.19.0 milestone Aug 5, 2021
@heitorlessa heitorlessa changed the title refactor(feature-flags): re-add debug log for all features evaluation" refactor(feature-flags): add debug for all features evaluation" Aug 5, 2021
@heitorlessa heitorlessa merged commit d9fe499 into aws-powertools:develop Aug 5, 2021
@heitorlessa heitorlessa deleted the chore/feat-flags-all-features-debug branch August 5, 2021 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature New feature or functionality internal Maintenance changes size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.19.0
Development

Successfully merging this pull request may close these issues.
2 participants
@heitorlessa @codecov-commenter